Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Extend Azure secret validation #12007

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

xperimental
Copy link
Collaborator

@xperimental xperimental commented Feb 20, 2024

What this PR does / why we need it:

For some of the values in the Azure storage secret the operator is able to do a check for validity, giving an early warning to the user instead of generating the Loki configuration and making the components then crash on invalid input.

This PR adds a validation for the Azure environment for which we know the valid values and a basic check for the account-key rejecting values that are not valid Base64.

Which issue(s) this PR fixes:

LOG-4571

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • CHANGELOG.md updated

@periklis periklis changed the title operator: Extend Azure secret validation feat(operator): Extend Azure secret validation Feb 21, 2024
@periklis periklis merged commit aeaefe6 into grafana:main Feb 21, 2024
18 checks passed
@xperimental xperimental deleted the azure-secret-validation branch February 22, 2024 12:56
onelapahead pushed a commit to onelapahead/loki that referenced this pull request Feb 22, 2024
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants