Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tutorial: create alert rules with logs #103

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

tonypowa
Copy link
Collaborator

@tonypowa
Copy link
Collaborator Author

@Jayclifford345
ready for review 🍞 ☕

Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Lets put in staging to test

@Jayclifford345 Jayclifford345 merged commit 455b523 into staging Aug 29, 2024
2 checks passed
Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonypowa after running through the tutorial in staging these are the issues I found. Other than that looks great

grafana/alerting-loki-logs/step1.md Show resolved Hide resolved
grafana/alerting-loki-logs/step1.md Show resolved Hide resolved
grafana/alerting-loki-logs/step1.md Show resolved Hide resolved
grafana/alerting-loki-logs/step2.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants