[grafana] correct array formatting for grafana.ini

[nathwill]

fixes array format in configmap grafana.ini.

previously produced: org_mapping = ["a" "b" "c"], which grafana did not apply correctly
now produces: org_mapping = ["a", "b", "c"], which grafana applies correctly

of note:
for some reason this only seems to work when applied as TOML style array lists ["a", "b", "c"], even though the file type is nominally ini, which would suggest the following would actually be appropriate:

org_mapping[] = "a"
org_mapping[] = "b"
org_mapping[] = "c"

🤷

[CLAassistant]

All committers have signed the CLA.

[jkroepke]

Could you link documentation, where array style is used?

for org_mapping, I can only find a space separated string:

org_mapping = org_foo:org_foo:Viewer org_bar:org_bar:Editor *:org_baz:Editor

[nathwill]

@jkroepke yeah this was documented here: https://grafana.com/docs/grafana/latest/setup-grafana/configure-security/configure-authentication/okta/#org-roles-mapping-example and seems to work that way... the helm chart currently is doing space-separated but inside square brackets, so not even the way you described either

[jkroepke]

but with the join method, it will result into:

org_mapping = [a,b,c]

not

org_mapping = ["a","b","c"]

[nathwill]

yeah, string-wrapping is optional as it's written and afaik only required when spaces are involved (?)... if we want to enforce string-wrapping i can update the PR accordingly, just wanted to only do the minimal needed so it could be made to work via values...

in our patched version of the chart we're passing values in like this:

    org_mapping:
    - '"SRE:1:Admin"'
    - '"Support:1:Editor"'
    - '"Data Scientists:1:Editor"'
    - '"Developers:1:Editor"'

which produces

org_mapping = ["SRE:1:Admin", "Support:1:Editor", "Data Scientists:1:Editor", "Developers:1:Editor"]

[jkroepke]

instead join, consider using toJson and take not of CI failures

[nathwill]

cool, i like it.

[jkroepke]

For conistancy reasons, could you has this to the config section (15 lines above) as well?