[grafana-sampling] add batch config options and k8s.pod.name to metrics dimensions #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs gen dimensions Signed-off-by: Robbie Lankford <[email protected]>
Signed-off-by: Robbie Lankford <[email protected]>
petewall
approved these changes
Sep 24, 2024
t00mas
approved these changes
Sep 24, 2024
rlankfo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes batch processing options configurable for the deployment and statefulset batch processors. Additionally, k8s.pod.name is added to the set of default dimensions to avoid issue with faulty target_info metric generation.