[loki-distributed] fix: force nginx gateway to resolve upstream hostname on missing locations #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsicart
changed the title
rsicart
force-pushed
the
rsi/loki-distributed-force-nginx-resolve-dns-proxy-pass
branch
from
02071bf
to
2b1a7a4
Compare
There was a problem hiding this comment.
Hey there @rsicart, thanks for the contribution, Have you tested it ?
helm template works correctly. Installing the chart locally in a kind cluster works fine, gateway is Running and nginx config syntax is ok: |
rsicart
force-pushed
the
rsi/loki-distributed-force-nginx-resolve-dns-proxy-pass
branch
from
2b1a7a4
to
90e60bf
Compare
zanhsieh
requested changes
Aug 10, 2024
There was a problem hiding this comment.
@rsicart Could you please address the requested changes and fix CI lint error ? Thank you!
…e on missing locations Signed-off-by: R.Sicart <[email protected]> In order to force nginx to resolve hostnames in proxy_pass directive, we need to set a variable and use it in proxy_pass. Otherswise nginx only resolves hostnames at boot time.
Signed-off-by: R.Sicart <[email protected]>
rsicart
force-pushed
the
rsi/loki-distributed-force-nginx-resolve-dns-proxy-pass
branch
from
0ab10d4
to
648d633
Compare
zanhsieh
approved these changes
Aug 12, 2024
Sheikh-Abubaker
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to force nginx to resolve hostnames in proxy_pass directive, we
need to set a variable and use it in proxy_pass. Otherswise nginx only
resolves hostnames at boot time.