[promtail] Add automount option for service account and pod #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emilkor1 <[email protected]>
Signed-off-by: emilkor1 <[email protected]>
zanhsieh
approved these changes
Feb 27, 2024
|
Duplicate PR: #2991 |
|
@emilkor1 my PR covers grafana only. Not promtail, this is PR is still valid. |
|
Thanks for letting me know.. was too quick there |
|
Can someone look at this? @unguiculus @Whyeasy |
|
For security hardening we also need this. Any reason why this does not get merged? |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
|
@zanhsieh - I'm not an official promtail maintainer, I point this PR to you back. Feel to merge. |
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Aug 28, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [promtail](https://grafana.com/loki) ([source](https://togithub.com/grafana/helm-charts)) | patch | `6.16.4` -> `6.16.5` | --- ### Release Notes <details> <summary>grafana/helm-charts (promtail)</summary> ### [`v6.16.5`](https://togithub.com/grafana/helm-charts/releases/tag/promtail-6.16.5) [Compare Source](https://togithub.com/grafana/helm-charts/compare/promtail-6.16.4...promtail-6.16.5) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] Add automount option for service account and pod by [@​emilkor1](https://togithub.com/emilkor1) in [https://github.com/grafana/helm-charts/pull/2990](https://togithub.com/grafana/helm-charts/pull/2990) **Full Changelog**: grafana/helm-charts@grafana-sampling-1.0.1...promtail-6.16.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <[email protected]>
kodiakhq bot
referenced
this pull request
in cloudquery/helm-charts
Sep 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [promtail](https://grafana.com/loki) ([source](https://togithub.com/grafana/helm-charts)) | patch | `6.16.4` -> `6.16.5` | --- ### Release Notes <details> <summary>grafana/helm-charts (promtail)</summary> ### [`v6.16.5`](https://togithub.com/grafana/helm-charts/releases/tag/promtail-6.16.5) [Compare Source](https://togithub.com/grafana/helm-charts/compare/promtail-6.16.4...promtail-6.16.5) Promtail is an agent which ships the contents of local logs to a Loki instance #### What's Changed - \[promtail] Add automount option for service account and pod by [@​emilkor1](https://togithub.com/emilkor1) in [https://github.com/grafana/helm-charts/pull/2990](https://togithub.com/grafana/helm-charts/pull/2990) **Full Changelog**: grafana/helm-charts@grafana-sampling-1.0.1...promtail-6.16.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure recommended actions suggests disabling automount of API credentials.