Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set stream path to check prefix, not full string. #61

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Set stream path to check prefix, not full string. #61

merged 4 commits into from
Sep 25, 2023

Conversation

SandersAaronD
Copy link
Contributor

@SandersAaronD SandersAaronD commented Sep 22, 2023 •
edited
Loading

Untested but seems reasonable

sd2k
sd2k requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 suggested change which makes this work locally with the both older & the fixed version of @grafana/experimental.

Could you also update the CHANGELOG? 🙏

pkg/plugin/stream.go Outdated Show resolved Hide resolved
@SandersAaronD
Copy link
Contributor Author

SandersAaronD commented Sep 22, 2023 •
edited
Loading

Just 1 suggested change which makes this work locally with the both older & the fixed version of @grafana/experimental.

Could you also update the CHANGELOG? 🙏

This is done and version is bumped to 0.2.1, it would be helpful if we could push to release sooner rather than later. Going to change this out of draft.

@SandersAaronD SandersAaronD self-assigned this Sep 22, 2023
@SandersAaronD SandersAaronD mentioned this pull request Sep 22, 2023
Closed
@SandersAaronD SandersAaronD marked this pull request as ready for review September 22, 2023 17:25
sd2k
sd2k approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sd2k sd2k merged commit 8020e88 into main Sep 25, 2023
1 check passed
@sd2k sd2k deleted the sandersaarond/uncross-streams branch September 25, 2023 07:12
SandersAaronD pushed a commit that referenced this pull request Oct 27, 2023
@joey-grafana
Merge pull request #61 from grafana/joey/generic-config-section-descr…
9e36eaf 
…iption-type

Update GenericConfigSection description type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd2k sd2k sd2k approved these changes

Assignees

@SandersAaronD SandersAaronD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandersAaronD @sd2k