fix: return 'true' from enabled if API call returns 405 Method Not Allowed #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowed The backend intentionally returns a 405 if a GET request is sent to the search endpoint, so we can count that as correctly enabled.
sd2k
force-pushed
the
vector-check-method-not-allowed
branch
from
5f63510
to
5d5ca54
Compare
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
fix: return 'true' from enabled if API call returns 405 Method Not Allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend intentionally returns a 405 if a GET request
is sent to the search endpoint, so we can count that as correctly enabled.