feat(AppHeader): Revamp header #230
Open
+217
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
# Conflicts: # src/pages/ProfilesExplorerView/components/SceneExploreDiffFlameGraph/components/SceneDiffFlameGraph/SceneDiffFlameGraph.tsx # src/pages/ProfilesExplorerView/components/SceneProfilesExplorer/components/Header.tsx
grafakus
commented
Oct 21, 2024
| pageContainer: css` | ||
| display: flex; | ||
| flex-direction: column; | ||
| padding: ${theme.spacing(1)} ${theme.spacing(2)} ${theme.spacing(2)} ${theme.spacing(2)}; |
There was a problem hiding this comment.
The change in this file is just to remove some padding at the top
grafakus
commented
Oct 21, 2024
| height: number; | ||
| }; | ||
|
|
||
| export function PyroscopeLogo({ width, height }: PyroscopeLogoProps) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): is blocked by #229
A revamp of the header to be a bit more consistent with the other "Explore" apps: we exchange a bit of vertical real estate in favour of more horizontal real estate. We also "isolate" the "Exploration" row so we can iterate on it later.
📖 Summary of the changes
Most of the changes consist in modifying how the labels appear on the screen (on top of the input instead of being inline, with a greyish background colour):
See diff tab for specific comments.
🧪 How to test?
The build should pass