-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanlogger: fix double logging of caller information #604
Merged
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2d8e068 - Browse repository at this point
Copy the full SHA 2d8e068View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ed57a - Browse repository at this point
Copy the full SHA d8ed57aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6d3111 - Browse repository at this point
Copy the full SHA e6d3111View commit details -
Configuration menu - View commit details
-
Copy full SHA for e93c3a0 - Browse repository at this point
Copy the full SHA e93c3a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c3d911 - Browse repository at this point
Copy the full SHA 2c3d911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 647f153 - Browse repository at this point
Copy the full SHA 647f153View commit details
Commits on Oct 10, 2024
-
Don't bother with checking for go-kit/log stack frames until we've se…
…en SpanLogger This makes the cost of spanlogger.Caller negligible for use outside of SpanLogger: │ SpanLoggerAwareCaller/with_go-kit's_Caller-10 │ SpanLoggerAwareCaller/with_dskit's_spanlogger.Caller-10 │ │ sec/op │ sec/op vs base │ comparison-after-step-2.txt 927.5n ± 5% 932.1n ± 2% ~ (p=0.093 n=6) │ SpanLoggerAwareCaller/with_go-kit's_Caller-10 │ SpanLoggerAwareCaller/with_dskit's_spanlogger.Caller-10 │ │ B/op │ B/op vs base │ comparison-after-step-2.txt 732.5 ± 0% 733.0 ± 0% ~ (p=0.636 n=6) │ SpanLoggerAwareCaller/with_go-kit's_Caller-10 │ SpanLoggerAwareCaller/with_dskit's_spanlogger.Caller-10 │ │ allocs/op │ allocs/op vs base │ comparison-after-step-2.txt 9.000 ± 0% 9.000 ± 0% ~ (p=1.000 n=6) ¹ ¹ all samples are equal
Configuration menu - View commit details
-
Copy full SHA for 9e662ca - Browse repository at this point
Copy the full SHA 9e662caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c681b - Browse repository at this point
Copy the full SHA 57c681bView commit details -
Address PR feedback: use const in test
Co-authored-by: Arve Knudsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2b6372 - Browse repository at this point
Copy the full SHA d2b6372View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.