Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otelcol): allow event extraction from spans in spanlogs (grafana#2427) #2433

Merged
merged 4 commits into from
Jan 20, 2025
Merged

feat(otelcol): allow event extraction from spans in spanlogs (grafana#2427) #2433

merged 4 commits into from
Jan 20, 2025

Conversation

steve-hb
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Fixes #2427

Notes to the Reviewer

I'm not sure whether config converter update is needed here.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@steve-hb steve-hb requested review from clayton-cornell and a team as code owners January 16, 2025 23:11
@steve-hb steve-hb changed the title Spanlogs event feat(otelcol): allow event extraction from spans in spanlogs (grafana#2427) Jan 16, 2025
wildum
wildum reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code looks good, just two comments on changelog and doc

CHANGELOG.md Outdated Show resolved Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.spanlogs.md Outdated Show resolved Hide resolved
wildum
wildum reviewed Jan 17, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 17, 2025
clayton-cornell
clayton-cornell reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the example covers the bits it needs to, the doc input is OK from my side of things.

wildum
wildum approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks again! If you could just rebase your branch with main to get the new Go version to pass the build, then I can merge it

@steve-hb
Copy link
Contributor Author

Noticed the problem in CI too, rebased and just waiting for CI to confirm :)

@wildum wildum merged commit adf80db into grafana:main Jan 20, 2025
16 checks passed
@steve-hb steve-hb deleted the spanlogs_event branch January 20, 2025 13:36
clayton-cornell pushed a commit that referenced this pull request Jan 21, 2025
@steve-hb @clayton-cornell
feat(otelcol): allow event extraction from spans in spanlogs (#2427) (#…
94aee97 
…2433)

* feat(otelcol): allow event extraction from spans in spanlogs (#2427)

* Move feature changelog to unreleased main

* Improve spanlogs event documentation examples and performance warning

* Fix documentation issue regarding the attributes set for events in otelcol.connector.spanlogs#Example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract log entries from events
3 participants
@steve-hb @wildum @clayton-cornell