-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and lint discovery.azure to discovery.dockerswarm #2403
Conversation
💻 Deploy preview deleted. |
Related issue #2411 |
docs/sources/reference/components/discovery/discovery.consul.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/discovery/discovery.docker.md
Outdated
Show resolved
Hide resolved
@dehaansa There's been quite a few changes since you last checked this. Might be worth a re-check. I've noticed inconsistent use of double quotes in the Usage sections. I'm not sure if this is intentional or not. For example in
and in
|
7ea0e3f
to
5d245a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the better use of space in the tables, thanks!
docs/sources/reference/components/discovery/discovery.consul.md
Outdated
Show resolved
Hide resolved
I think the second example is preferrable - when working with strings, we should always use "" syntax. |
I'll do a pass through the Usage and Examples to check for this and update. |
* Update discover azure and consul topics * Update dogitalocean, dns, and docker topics * Additional style cleanup * Linting updates and edits * Syntax and mardown cleanup * Minor updates from review * Add missing descriptions and add OSS badge * Fix a typo and two sentences * Simplify link definitions * Fix typo and remove duplicated frontmatter * Fix literal string quoting in examples (cherry picked from commit 63ba016)
* Update discover azure and consul topics * Update dogitalocean, dns, and docker topics * Additional style cleanup * Linting updates and edits * Syntax and mardown cleanup * Minor updates from review * Add missing descriptions and add OSS badge * Fix a typo and two sentences * Simplify link definitions * Fix typo and remove duplicated frontmatter * Fix literal string quoting in examples (cherry picked from commit 63ba016)
* Update discover azure and consul topics * Update dogitalocean, dns, and docker topics * Additional style cleanup * Linting updates and edits * Syntax and mardown cleanup * Minor updates from review * Add missing descriptions and add OSS badge * Fix a typo and two sentences * Simplify link definitions * Fix typo and remove duplicated frontmatter * Fix literal string quoting in examples (cherry picked from commit 63ba016)
* Update discover azure and consul topics * Update dogitalocean, dns, and docker topics * Additional style cleanup * Linting updates and edits * Syntax and mardown cleanup * Minor updates from review * Add missing descriptions and add OSS badge * Fix a typo and two sentences * Simplify link definitions * Fix typo and remove duplicated frontmatter * Fix literal string quoting in examples (cherry picked from commit 63ba016)
PR Description
Splitting Discovery updates into multiple PRs to make reviews a bit easier.
Changes include:
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist