Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netframework link destinations #7102

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

clayton-cornell
Copy link
Contributor

PR Description

Document URL:
https://grafana.com/docs/agent/latest/flow/reference/components/prometheus.exporter.windows/#collectors-list

The netframework_* links reference a nonexistent file. They should link to https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.netframework.md

Which issue(s) this PR fixes

Fixes #14217

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.43 labels Jan 28, 2025
@clayton-cornell clayton-cornell requested a review from a team January 28, 2025 17:25
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me :)

@clayton-cornell clayton-cornell merged commit 89737fc into main Jan 28, 2025
10 checks passed
@clayton-cornell clayton-cornell deleted the docs/fix_bad_link_prometheus.exporter.windows branch January 28, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v0.43 type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants