Fix issue with unnecessary config reload in static mode #6977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
When a config reload is triggered, the config shouldn't be reloaded if it hasn't changed. Unfortunately, there was a bug which prevented this for the "metrics" and "logs" subsystems:
X-Agent-Id
header isn't in the user-defined config.scrape_configs
/static_configs
section, there might be atargets: [localhost]
which was added by default by Promtail because the user didn't set it explicitlyFor example, when using static_mode.yaml.txt, the Agent tries interprets the new config as example_incoming.yaml.txt. This doesn't match the way it thinks the "current" config that it uses is defined(example_running.yaml.txt), so it does a config reload. This issue is not present in Flow - it's only in static mode.
There might also be similar issues that cause mismatch in configs. It's possible that I don't see all such issues, since my config file is using very few functionality. The only sure way of eliminating these issues that I can think of is to store the incoming config in a string, as this PR is doing.
Notes to the Reviewer
This is a prerequisite for #6971
PR Checklist