feat: alternative titles #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the PR, however i'm not set on the design. I see you used a MyAnimeList would provide the language of the title:
Nautiljon also:
I see an interest to distinguish the different titles, even within a same language. For example you could store Japanese titles in Romaji, Kanjis, and Hiragana/Katakana. There's a similar discussion about the comicinfo format. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alternative titles to series.
Not sure about edit dialog, it might be better to have a separate tab for it but having a whole tab just for alt. titles didn't feel right
Closes #878