Heavily revised handling of response types #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le. Instead of doing an extraneous sort in the signature generation logic, require SWIFT_DETERMINISTIC_HASHING be set for the tests (that's what it's there for, after all). Moves the OAuth implementations to their own subfolder.
…ingle-entity responses, and require InnerType to be either OneRosterBase or Array<OneRosterBase>. Make the single-entity version of OneRosterClient.request() return the inner type instead of the wrapper.
…ing test for the single-entity request method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a semver-major API-breaking change, obviously.
Cleans up the OAuth1 code a bit and adds a missing test, too.