Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow symlink tests #1087

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add follow symlink tests #1087

merged 1 commit into from
Nov 13, 2024

Conversation

Corentin-pro
Copy link
Contributor

@Corentin-pro Corentin-pro commented Nov 13, 2024

Added 2 tests for the new follow_symlink options.

The tests correctly fail if follow_symlink is set to False.

The code coverage slightly increases, this only adds the line 185 of src/watchdog/observers/inotify_c.py corresponding to

if follow_symlink:
    event_mask &= ~InotifyConstants.IN_DONT_FOLLOW

PS : a minor code style was automatically fixed in src/watchdog/observers/fsevents.py.

@BoboTiG BoboTiG merged commit 9df81ab into gorakhargosh:master Nov 13, 2024
21 checks passed
@BoboTiG
Copy link
Collaborator

BoboTiG commented Nov 13, 2024

Thanks a lot @Corentin-pro 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants