refactor: prefer typed params for API funcs #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aofei
force-pushed
the
typed-params
branch
4 times, most recently
from
a1f50a7 to
41deb10
Compare
- Introduce `SpriteName`, `SpriteCostumeName`, `SpriteAnimationName`,
`SoundName`, `BackdropName`, `WidgetName`.
- Prefer func overloading over using `interface{}` or variadic params as
optional params.
Signed-off-by: Aofei Sheng <[email protected]>
JiepengTan
approved these changes
Dec 4, 2024
JiepengTan
added a commit
to JiepengTan/spx
that referenced
this pull request
Dec 5, 2024
- Introduce `SpriteName`, `SpriteCostumeName`, `SpriteAnimationName`,
`SoundName`, `BackdropName`, `WidgetName`.
- Prefer func overloading over using `interface{}` or variadic params as
optional params.
Signed-off-by: Aofei Sheng <[email protected]>
nighca
pushed a commit
that referenced
this pull request
Dec 5, 2024
- Introduce `SpriteName`, `SpriteCostumeName`, `SpriteAnimationName`,
`SoundName`, `BackdropName`, `WidgetName`.
- Prefer func overloading over using `interface{}` or variadic params as
optional params.
Signed-off-by: Aofei Sheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpriteName,SpriteCostumeName,SpriteAnimationName,SoundName,BackdropName,WidgetName.interface{}or variadic params as optional params.