Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase authentication for Merchant Sign Up #54

Merged
merged 73 commits into from
Jun 29, 2020
Merged

Add Firebase authentication for Merchant Sign Up #54

merged 73 commits into from
Jun 29, 2020

Commits on Jun 18, 2020

  1. Create Sign Up page for merchants

    @karenfrilya97
    karenfrilya97 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8778eda View commit details
    Browse the repository at this point in the history

  2. Fix lint errors

    @karenfrilya97
    karenfrilya97 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    0c3ab97 View commit details
    Browse the repository at this point in the history

  3. Make Sign Up page resolutions smaller to fit laptops

    @karenfrilya97
    karenfrilya97 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    695dd2d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Add JSDoc comments for exported components

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    78d36cd View commit details
    Browse the repository at this point in the history

  2. rename OnboardingCard to SignUpCard to standardise

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    520bb0a View commit details
    Browse the repository at this point in the history

  3. Remove params in JSDoc comment of components

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2f9d890 View commit details
    Browse the repository at this point in the history

  4. Rename MerchantLandingPage to LandingPage and MerchantSignUpPage to S… 

    …ignUpPage
    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2ef64c7 View commit details
    Browse the repository at this point in the history

  5. Correct the Sign in link in Sign Up page

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ec119ba View commit details
    Browse the repository at this point in the history

  6. Update web/src/components/merchant/sign-up/SignUpCard.tsx 

    Co-authored-by: Caryn Heng <[email protected]>
    @karenfrilya97 @hzxcaryn
    karenfrilya97 and hzxcaryn authored Jun 19, 2020
    Configuration menu
    Copy the full SHA
    3ba1f0c View commit details
    Browse the repository at this point in the history

  7. Add missing import {Link} statement in SignUpCard

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    c8e706b View commit details
    Browse the repository at this point in the history

  8. Import gpay-logo.svg directly as React Component

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2cdbd6b View commit details
    Browse the repository at this point in the history

  9. Strip input tag style in index.css file instead of FormRox.tsx

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9407acb View commit details
    Browse the repository at this point in the history

  10. Fix lint error

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    17515ed View commit details
    Browse the repository at this point in the history

  11. Change Sign Up button from input element to MUI Button element

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    8470e94 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' of github.com:googleinterns/gpay-group-buy into… 

    … karen/sign-up-form
    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    470f7c2 View commit details
    Browse the repository at this point in the history

  13. Vertically centralise SignUpCard in SignUpPage

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7b0eb42 View commit details
    Browse the repository at this point in the history

  14. Add input name in FormRow

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    dee7e44 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' of github.com:googleinterns/gpay-group-buy into… 

    … karen/sign-up-handling
    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    1d7e6b1 View commit details
    Browse the repository at this point in the history

  16. Add handlers for merchants' sign up form

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    61aa094 View commit details
    Browse the repository at this point in the history

  17. Remove logging statements for debugging

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ecec1e2 View commit details
    Browse the repository at this point in the history

  18. Add a new user account to Firebase for signed up merchant

    @karenfrilya97
    karenfrilya97 committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    35e0082 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. fix lint errors

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d7afbff View commit details
    Browse the repository at this point in the history

  2. Use react hooks

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    25f36e6 View commit details
    Browse the repository at this point in the history

  3. Make Group Buy Merchant header smaller

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ac264e8 View commit details
    Browse the repository at this point in the history

  4. Show individual error for each form field

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    3d4fb50 View commit details
    Browse the repository at this point in the history

  5. Refactor constants into a separate file

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    0252c86 View commit details
    Browse the repository at this point in the history

  6. Fix lint error

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    309f11c View commit details
    Browse the repository at this point in the history

  7. Check form fields in handleSubmit

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    5bb5928 View commit details
    Browse the repository at this point in the history

  8. Remove unused interface

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    52f2bc1 View commit details
    Browse the repository at this point in the history

  9. Enlarge error message font size

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    7e9ed26 View commit details
    Browse the repository at this point in the history

  10. Align Sign Up Form labels with inputs

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b0856f4 View commit details
    Browse the repository at this point in the history

  11. Remove unused const

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    3681d50 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' of github.com:googleinterns/gpay-group-buy into… 

    … karen/sign-up-handling
    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    5ea51a1 View commit details
    Browse the repository at this point in the history

  13. Remove unused const

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    0d3203b View commit details
    Browse the repository at this point in the history

  14. Refactor function to format phrase into camelCase

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1ea4842 View commit details
    Browse the repository at this point in the history

  15. Update JSDoc comment for FormRow

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b39a28b View commit details
    Browse the repository at this point in the history

  16. Add comments to explain Sign Up form checks

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    42f7018 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'karen/sign-up-handling' of github.com:googleinterns/gpa… 

    …y-group-buy into karen/firebase-sign-up
    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    cfe97f9 View commit details
    Browse the repository at this point in the history

  18. Use hooks in firebase code

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ed7983c View commit details
    Browse the repository at this point in the history

  19. Append REACT_APP_ in front of env var names

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1626701 View commit details
    Browse the repository at this point in the history

  20. Readd logic that was removed due to merging

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    9d96fef View commit details
    Browse the repository at this point in the history

  21. Readd components that were deleted due to merging

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    2e3b9c9 View commit details
    Browse the repository at this point in the history

  22. Remove unused autobind-decorator

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    af6e927 View commit details
    Browse the repository at this point in the history

  23. Refactor firebase auth initialisation into src/firebase-auth.ts

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    2f1b38d View commit details
    Browse the repository at this point in the history

  24. Refactor firebase error messages into sign-up-errors.ts

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    90c2e23 View commit details
    Browse the repository at this point in the history

  25. Fix lint errors

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    8bf6aaa View commit details
    Browse the repository at this point in the history

  26. Add comment about Firebase auth

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d450e4b View commit details
    Browse the repository at this point in the history

  27. Refactor Firebase config JS object out

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    e1599a3 View commit details
    Browse the repository at this point in the history

  28. Merge branch 'master' of github.com:googleinterns/gpay-group-buy into… 

    … karen/sign-up-handling
    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    134bfbf View commit details
    Browse the repository at this point in the history

  29. Show Firebase error below relevant field

    @karenfrilya97
    karenfrilya97 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    fd91670 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Add environment variables to web/app.yaml

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    d1bc70f View commit details
    Browse the repository at this point in the history

  2. Add comment to web/app.yaml

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5a15126 View commit details
    Browse the repository at this point in the history

  3. Refactor handleFirebaseSignUp into a separate function

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    bbc5722 View commit details
    Browse the repository at this point in the history

  4. Use async/await instead of promises

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5d2e852 View commit details
    Browse the repository at this point in the history

  5. Fix typos in constants/sign-up-errors.ts

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3cefe11 View commit details
    Browse the repository at this point in the history

  6. Add comment to toCamelCase function

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    9bbe413 View commit details
    Browse the repository at this point in the history

  7. Move handleFirebaseSignUp comment to JSDoc comment

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    ce31064 View commit details
    Browse the repository at this point in the history

  8. Remove typo in web/app.yaml

    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    ef8de81 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'karen/sign-up-handling' of github.com:googleinterns/gpa… 

    …y-group-buy into karen/firebase-sign-up
    @karenfrilya97
    karenfrilya97 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    26892a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Use hook to separate logic from UI in SignUpCard

    @karenfrilya97
    karenfrilya97 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    b004e3f View commit details
    Browse the repository at this point in the history

  2. Use react-hook-form library for Merchant SignUpForm

    @karenfrilya97
    karenfrilya97 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    2a6b7ba View commit details
    Browse the repository at this point in the history

  3. Use to-camel-case library instead of custom function

    @karenfrilya97
    karenfrilya97 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    aaee377 View commit details
    Browse the repository at this point in the history

  4. Disable Sign Up button until form is valid

    @karenfrilya97
    karenfrilya97 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    147d81d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Create useSignUpForm hook to separate logic from UI

    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    28c137a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'karen/sign-up-handling' of github.com:googleinterns/gpa… 

    …y-group-buy into karen/firebase-sign-up
    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    8ccdf55 View commit details
    Browse the repository at this point in the history

  3. Update web/src/firebase-auth.ts

    @karenfrilya97
    karenfrilya97 authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    7e402da View commit details
    Browse the repository at this point in the history

  4. Use switch-case instead of if-else when handling firebase error

    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    ec69418 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'karen/firebase-sign-up' of github.com:googleinterns/gpa… 

    …y-group-buy into karen/firebase-sign-up
    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    47491fa View commit details
    Browse the repository at this point in the history

  6. Fix lint errors

    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4ddd868 View commit details
    Browse the repository at this point in the history

  7. Fix bug in firebase-auth

    @karenfrilya97
    karenfrilya97 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    2e9f2c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Merge branch 'master' of github.com:googleinterns/gpay-group-buy into… 

    … karen/firebase-sign-up
    @karenfrilya97
    karenfrilya97 committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0661472 View commit details
    Browse the repository at this point in the history

  2. Remove unused import not removed during merge

    @karenfrilya97
    karenfrilya97 committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    893bde0 View commit details
    Browse the repository at this point in the history

  3. Rephrase sign up error message

    @karenfrilya97
    karenfrilya97 committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0f98cfa View commit details
    Browse the repository at this point in the history