Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with sparse masters when .notdef contain cubic curves #772

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix issue with sparse masters when .notdef contain cubic curves #772

merged 2 commits into from
Aug 1, 2023

Commits on Aug 1, 2023

  1. add reproducer for #501

    @anthrotype
    anthrotype committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e390805 View commit details
    Browse the repository at this point in the history

  2. use empty .notdef for sparse TTF masters 

    previously we were copying one from the default master, but if this contains cubic curves our own check fails because the .notdef we inserted in the sparse masters OutlineCompiler was not passed through cu2qu...
Our intention is to have sparse masters not participate in the interpolation of that particular glyph so we make it empty (gid0=.notdef still needs to be there in a valid TTF so we must have one).
Currently the same trick does not work for CFF2 variable fonts (fonttools/fonttools#3233) but those are fine with cubics in .notdef glyph any way.. For now at least
    @anthrotype
    anthrotype committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8d676d9 View commit details
    Browse the repository at this point in the history