Export variable instances as DSv5 variable-fonts #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next commits we will be generating DesignSpace variable-font’s for them, and these values will generate noise in the lib even though they are not actually set in the source.
Introduces some formatting change, to minimize the diff in the next commit.
anthrotype
reviewed
Feb 1, 2024
Export Glyphs 3 as DesignSpace v5 variable-fonts, setting their custom parameters is the variable-font lib, mainly using the "public.fontInfo" key.
khaledhosny
force-pushed
the
variable-instance
branch
from
1e24809
to
257ced9
Compare
anthrotype
reviewed
Feb 1, 2024
anthrotype
reviewed
Feb 1, 2024
| ufo_varfont.lib["public.fontInfo"] = info | ||
|
|
||
| for key in ufo.lib: | ||
| ufo_varfont.lib[key] = ufo.lib[key] |
There was a problem hiding this comment.
I wonder, what could end up here? Any params for which there isn't a corresponding fontinfo key basically? I guess it's fine to store them here, even though they won't be used right know by anybody.
There was a problem hiding this comment.
Yes. They might be useful for round-tripping, though this PR does not handle it right now.
|
This does not round-trip back to .glyphs, if I understand correctly, right? How hard do you reckon will that be? Maybe we could file an issue as a TODO for later. |
|
I don’t use ufo2glyphs myself, but I might look into it later. I’ll file an issue for now. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export Glyphs 3 as DesignSpace v5 variable-fonts, setting their custom parameters is the variable-font lib, mainly using the "public.fontInfo" key.