Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set primary script if we know it #746

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Only set primary script if we know it #746

merged 1 commit into from
Oct 4, 2023

Conversation

simoncozens
Copy link
Contributor

@simoncozens simoncozens commented Oct 4, 2023 •
edited
Loading

Fixes #745.

@simoncozens simoncozens marked this pull request as ready for review October 4, 2023 11:02
@eliheuer eliheuer mentioned this pull request Oct 4, 2023
Closed
@simoncozens simoncozens merged commit 08a41fa into main Oct 4, 2023
11 checks passed
m4rc1e pushed a commit to m4rc1e/tools that referenced this pull request Oct 4, 2023
@simoncozens @m4rc1e
Only set primary script if we know it (googlefonts#746)
6ad7f80
@simoncozens simoncozens deleted the fix-indeterminate-primary-script branch May 30, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gftools packager error: Cannot set google.fonts_public.FamilyProto.primary_script to None
1 participant
@simoncozens