Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised we needed a command line wrapper around gftools.autohint (i.e. ttfautohint-py with our script-detection logic added) for the ninja builder, because everything the ninja builder calls has to be a command line utility.
But I also realised that it's useful for us to provide a command-line wrapper around ttfautohint-py anyway. The whole point of ttfautohint-py is that it gives you an easy way to install the latest version of ttfautohint, not just the one in your distribution (which can be quite old), and the whole point of gftools is that you can install it and get the latest version of everything you need to build fonts. But installing ttfautohint-py doesn't give you an easy way to run the latest version of ttfautohint.
I also needed something to get the right script for auto hinting full Noto fonts; these contain a Latin set but may be quite small. With our current script detection logic a large Latin set might overwhelm a small other set of glyphs, which are actually the ones you want to target for autohinting. The
discount_latin
argument ignores Latin glyphs when determining which is the primary script of a font .