-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder subset operation: exclude glyphs by name/codepoint/file #1020
Builder subset operation: exclude glyphs by name/codepoint/file #1020
Conversation
Based on logic from ufo_merge
Leverages/Expands on the (formally called) unicodes_by_donor to handle glyphs names also. Some type soup involved
9baaa3f
to
455c61a
Compare
I've just fixed the ufomerge bug and am happy with this if you are - ready for review? |
I don't think the failing test runs are on me, but let me know if I'm mistaken there Pushed documentation on the subset operation (see it rendered here) I wanted to pin (*note: the fix has not yet been released) |
Yes, please add a dependency on ufomerge>=1.8.1 |
@simoncozens Thanks Simon, all pinned now: 📌 1e0521a 📌 |
Nice, thank you! |
Adds support both on commandline and through YAML for glyphs to be excluded by either their name or codepoint.
All of the following now work (and yes, they would work together if something possessed you to do so):
Usage docs for the CLI:
The file format I've tried to be considerate/flexible: it's newline delimited, allowing either
//
or#
style comments (both in-line and on thier own line)Considerations:
ufomerge
's own CLI convention?ufomerge
that means excluding a glyph by name when using a named glyphset will remove its unicode: Dropping codepoint for a glyph already inufo1
included by codepoint & excluded by name ufomerge#28Happy to hear thoughts, feedback, emotions