Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[background image] Front-End updates (selectable, editable and transformable) #1783

Merged
merged 32 commits into from
Nov 15, 2024
Merged

[background image] Front-End updates (selectable, editable and transformable) #1783

merged 32 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. Make the background image selectable

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    62b2399 View commit details
    Browse the repository at this point in the history

  2. Use decomposedToTransform for backgroundImageSelectionAtPoint

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bfd3051 View commit details
    Browse the repository at this point in the history

  3. Make the background image editable

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2afc78f View commit details
    Browse the repository at this point in the history

  4. Remove unused import of copyBackgroundImage

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cb086a4 View commit details
    Browse the repository at this point in the history

  5. Add backgroundImageSelectionAtPointRect to support rect- and point-se… 

    …lection
    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    58ba359 View commit details
    Browse the repository at this point in the history

  6. Refactoring: Use transformPointObject instead of transformPoint

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    56c5632 View commit details
    Browse the repository at this point in the history

  7. selection-stroke for background image: move out of withSavedState

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6e27a5e View commit details
    Browse the repository at this point in the history

  8. Make background image work with transformation panel

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8d3cbab View commit details
    Browse the repository at this point in the history

  9. Add translation key for background image and update translation files 

    similar to previous names
    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6882cf0 View commit details
    Browse the repository at this point in the history

  10. Fix issue with selection when background image exists

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c3db48f View commit details
    Browse the repository at this point in the history

  11. Add interactive transformation for background images

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d1b366a View commit details
    Browse the repository at this point in the history

  12. Refactoring of: makeBackgroundImageChange()

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8739cbd View commit details
    Browse the repository at this point in the history

  13. Fix the interactive transformation issue (keyword: exponential scaling)

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9882d00 View commit details
    Browse the repository at this point in the history

  14. Update language files

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3610874 View commit details
    Browse the repository at this point in the history

  15. Replace fullComponentTransform and fullBackgroundImageTransform with … 

    …doFullTransform
    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cfbd756 View commit details
    Browse the repository at this point in the history

  16. Make two methods with _backgroundImageSelectionAtPointRect

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f39cfa0 View commit details
    Browse the repository at this point in the history

  17. Refactoring: for (const imageIndex of backgroundImageIndices)

    @ollimeier
    ollimeier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8443809 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Adding getBackgroundImageBounds to fontController + rectToPoints and … 

    …use it
    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8b54683 View commit details
    Browse the repository at this point in the history

  2. Make background images be selectable at last

    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    95827bb View commit details
    Browse the repository at this point in the history

  3. Remove obsolete comment

    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    074c34b View commit details
    Browse the repository at this point in the history

  4. pass getBackgroundImageBoundsFunc instead of full fontController

    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    331565c View commit details
    Browse the repository at this point in the history

  5. Removing another leftover comment

    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    594d575 View commit details
    Browse the repository at this point in the history

  6. Removing unused import

    @ollimeier
    ollimeier committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e14374b View commit details
    Browse the repository at this point in the history

  7. Rework how bg image bounds are computed; make bg images participate i… 

    …n align objects
    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3e36750 View commit details
    Browse the repository at this point in the history

  8. Make bg image participate in select all

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    756f250 View commit details
    Browse the repository at this point in the history

  9. Rename method

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    953cf7e View commit details
    Browse the repository at this point in the history

  10. Check rect -> img polygon intersection, not rect -> polygon bounds in… 

    …tersection, so rect select will work more intuitively on transformed images
    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e836007 View commit details
    Browse the repository at this point in the history

  11. Account for the possibility null bounds, if the image isn't available

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    081b392 View commit details
    Browse the repository at this point in the history

  12. Swap method and func getter

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4210d54 View commit details
    Browse the repository at this point in the history

  13. Minor optimization: we already have the image, let's make the bounds … 

    …rect inline
    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    127f036 View commit details
    Browse the repository at this point in the history

  14. Require rect to be defined

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    737338d View commit details
    Browse the repository at this point in the history

  15. Simplify

    @justvanrossum
    justvanrossum committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5995408 View commit details
    Browse the repository at this point in the history