Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background image infrastructure #1775

Merged
merged 39 commits into from
Nov 11, 2024
Merged

Background image infrastructure #1775

merged 39 commits into from
Nov 11, 2024

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Nov 9, 2024 •
edited
Loading

Part of #1660. This supersedes part of #1707.

Data structures:

  • BackgroundImage
  • RGBAColor
  • ImageType
  • ImageData

Protocols:

  • ReadBackgroundImage
  • WriteBackgroundImage

Backend implementations:

  • designspace
  • fontra

Support code:

  • copyFont
  • misc fontra-workflow updates
  • drop-background-images fontra-workflow filter

Front end:

  • Support for retrieving and caching bg images in FontController
  • An initial visualization layer for the bg image

@justvanrossum
Implement and test ds.getBackgroundImage()
793a5c8
@justvanrossum
Make UFOGlyph a dataclass with properly initialized defaults
57b78cc
@justvanrossum
Tweak image protocols
37d57c0
@justvanrossum
Tweak image protocol; ds: maintain mapping between image id and ufoPa…
090845b 
…th/img filename
@justvanrossum
Implement and test ds putBackgroundImage()
83a41e4
@justvanrossum
Add support for backgroundImage
faf4313
@justvanrossum
undefined works better because we rely on typeof, which is 'object' f…
54e3ea3 
…or null
@justvanrossum
Ignore backgroundImage for interpolation
4204f60
@justvanrossum
Adapt test expectations to reality
21191fc
@justvanrossum
Ignore backgroundImage for interpolation
043be7f
@justvanrossum
Improve class names
ce86d70
@justvanrossum
Copy background images
1935b98
@justvanrossum
Make getBackgroundImage pass through workflow filters
16000f4
@justvanrossum
Fix typing issues found by mypy
6aca7b0
@justvanrossum
Implement getBackgroundImage and putBackgroundImage for .fontra
22ba611
@justvanrossum
Improve assert
9dbc41f
@justvanrossum
'Merge' backgroundImage
3dca525
@justvanrossum
For (selected) binary data, dump SHA-1 hash instead of raw data
c5d08dd
@justvanrossum
Updated from .designspace project
8384ea5
@justvanrossum
Adjust expected results
211d45b
@justvanrossum
Implement and test drop-background-images filter
bb96a75
@justvanrossum
Undo accidental edit in wrong method; small optimization in correct m…
af8123b 
…ethod
@justvanrossum
Implement and test writing bg image to UFO
153948c
@justvanrossum
Fix + test writing bg image to new project
45d11b7
@justvanrossum justvanrossum marked this pull request as ready for review November 11, 2024 15:16
@justvanrossum justvanrossum merged commit 1af2432 into main Nov 11, 2024
5 checks passed
@justvanrossum justvanrossum deleted the background-image-infra branch November 11, 2024 18:46
This was referenced Nov 11, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justvanrossum