Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI font sources panel #1739

Merged
merged 20 commits into from
Oct 24, 2024
Merged

Improve UI font sources panel #1739

merged 20 commits into from
Oct 24, 2024

Conversation

ollimeier
Copy link
Collaborator

Fixes #1466

@ollimeier ollimeier mentioned this pull request Oct 22, 2024
Closed
@ollimeier
Copy link
Collaborator Author

This is how it looks currently when everything is folded (by default everything us unfolded):

Screenshot 2024-10-22 at 16 38 06

justvanrossum
justvanrossum reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and a question inline.

Additionally, I notice that the top margin ("General" vs "Regular") is a little different in folded state. Would be nice if they'd be the same.

src/fontra/views/applicationsettings/applicationsettings.html Outdated Show resolved Hide resolved
@ollimeier ollimeier mentioned this pull request Oct 23, 2024
Closed
@ollimeier ollimeier force-pushed the issue-1466-improve-ui-font-sources-panel branch from 1041783 to b72ddd6 Compare October 24, 2024 05:34
@ollimeier ollimeier force-pushed the issue-1466-improve-ui-font-sources-panel branch from e88af73 to 3db9945 Compare October 24, 2024 08:14
@ollimeier
Copy link
Collaborator Author

@justvanrossum The idea to store the 'isClosed' status works :)

Screen.Recording.2024-10-24.at.12.01.55.mp4

@ollimeier ollimeier marked this pull request as ready for review October 24, 2024 10:11
justvanrossum
justvanrossum reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments.

src/fontra/views/fontinfo/panel-sources.js Outdated Show resolved Hide resolved
src/fontra/views/fontinfo/panel-sources.js Outdated Show resolved Hide resolved
src/fontra/views/fontinfo/panel-sources.js Outdated Show resolved Hide resolved
src/fontra/views/fontinfo/panel-sources.js Outdated Show resolved Hide resolved
@ollimeier ollimeier merged commit 4dc4889 into main Oct 24, 2024
5 checks passed
@ollimeier ollimeier deleted the issue-1466-improve-ui-font-sources-panel branch October 24, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UI of font sources panel
2 participants
@ollimeier @justvanrossum