Support status code in UFO/Designspace #1402
Conversation
|
OK, it's weird. The tests fail here, but not on my machine: 
|
|
The issue is about the glyph status codes, not the status definitions. We probably need to write each source.customData to the corresponding glyph.lib. |
|
That's indeed weird: they also pass on my end. |
test-py/test_backends_fontra.py
Outdated
|
|
||
| async def test_copy_to_designspace_check_status_definitions(testFontraFont, newDSFont): | ||
| statusTestData = newStatusDefinitionsTestData() | ||
| await testFontraFont.putCustomData(statusTestData) |
There was a problem hiding this comment.
Ah, it may be this: you should not write to testFontraFont.
There was a problem hiding this comment.
But: the status definitions are already tested, I'm not sure what you're trying to accomplish with these additional tests.
There was a problem hiding this comment.
Like, what do you miss from the existing test_statusFieldDefinitions test func?
There was a problem hiding this comment.
You're right. Thanks.
There was a problem hiding this comment.
Can you please also address my other questions in this comment thread? I think you have added mostly redundant code.
There was a problem hiding this comment.
My bad. Yes, it's redundant code. I will delete this PR and branch in a second and start from scratch. I miss understood the whole task. I am very thankful for your early feedback so I did not run even longer into the wrong direction.
|
I am closing this, because of I misunderstood the task. |
Fixes #1364
I extended the unittests and it looks like everything works already. Do I miss something?