Merge pull request #1745 from googlefonts/issue-1743-use-modulo-for-d…

…oSelectPreviousNextSource Make use of modulo for doSelectPreviousNextSource
googlefonts · Oct 23, 2024 · c78e675 · c78e675
2 parents 058ec9b + 2b3acdd
commit c78e675
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/fontra/views/editor/editor.js b/src/fontra/views/editor/editor.js
@@ -42,6 +42,7 @@ import {
   isObjectEmpty,
   loadURLFragment,
   makeUPlusStringFromCodePoint,
+  modulo,
   parseSelection,
   range,
   readFromClipboard,
@@ -2801,9 +2802,10 @@ export class EditorController {
         ...this.sceneSettings.glyphLocation,
       });
     } else {
-      const numSources = varGlyphController.sources.length;
-      newSourceIndex =
-        (selectPrevious ? sourceIndex + numSources - 1 : sourceIndex + 1) % numSources;
+      newSourceIndex = modulo(
+        sourceIndex + (selectPrevious ? -1 : 1),
+        varGlyphController.sources.length
+      );
     }
     this.sceneController.scrollAdjustBehavior = "pin-glyph-center";
     this.sceneSettings.selectedSourceIndex = newSourceIndex;