Skip to content

Commit

Permalink
Remove checkboxWithoutLabel and use labeledCheckbox instead
Browse files Browse the repository at this point in the history
  • Loading branch information
ollimeier committed Oct 23, 2024
1 parent 020a6ee commit b94c733
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/fontra/client/core/ui-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ function didReorder(a, b) {
return false;
}

export function checkboxWithoutLabel(controller, key, options) {
return labeledCheckbox(false, controller, key, options);
}

export function labeledCheckbox(label, controller, key, options) {
const checkboxID = options?.id || `checkbox-${uniqueID()}-${key}`;
const inputWrapper = html.div();
Expand Down
4 changes: 2 additions & 2 deletions src/fontra/views/fontinfo/panel-cross-axis-mapping.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as html from "../core/html-utils.js";
import { addStyleSheet } from "../core/html-utils.js";
import { ObservableController } from "../core/observable-object.js";
import {
checkboxWithoutLabel,
labeledCheckbox,
labeledTextInput,
setupSortableList,
} from "../core/ui-utils.js";
Expand Down Expand Up @@ -508,7 +508,7 @@ function buildElementLocationsLabel(axis) {
}

function buildElementLocationsCheckboxes(axis, controller, checkboxId) {
const element = checkboxWithoutLabel(controller, axis.name);
const element = labeledCheckbox(null, controller, axis.name);
element.className = "fontra-ui-font-info-cross-axis-mapping-panel-checkboxes";
element.setAttribute(
"data-tooltip",
Expand Down

0 comments on commit b94c733

Please sign in to comment.