We no longer have to avoid reusing non-font-specific names #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Nov 14, 2024
| @@ -48,9 +48,6 @@ impl Work<Context, AnyWorkId, Error> for StatWork { | |||
| let reverse_names: HashMap<_, _> = static_metadata | |||
| .names | |||
| .iter() | |||
| // To match fontmake we should use the font-specific name range and not reuse | |||
| // a well-known name, even if the name matches. | |||
There was a problem hiding this comment.
happy to delete a confusing special case!
There was a problem hiding this comment.
Confused me when I put that code in and again today rofl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1105 on the python side made it possible to reuse non-font-specific names, make fontc consistent.
Makes
python resources/scripts/ttx_diff.py 'https://github.com/googlefonts/Exo-2.0#sources/Glyphs/Exo2-Italic.glyphs'andpython resources/scripts/ttx_diff.py 'https://github.com/googlefonts/atkinson-hyperlegible#sources/AtkinsonHyperlegible.glyphs'and hopefully others identical instead of different on(name, fvar).JMM if happy.