Normalize the order of glyf contours #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Nov 13, 2024
| @@ -755,7 +773,7 @@ def main(argv): | |||
| root = Path(".").resolve() | |||
| if root.name != "fontc": | |||
| sys.exit("Expected to be at the root of fontc") | |||
|
|
|||
| contours = glyph.xpath("./contour") | ||
| if len(contours) < 2: | ||
| continue | ||
| normalized = sorted(contours, key=lambda c: etree.tostring(c)) |
There was a problem hiding this comment.
do we even need to tostring? not sure how expensive it is, but all we need is some total order, can we get that from c itself?
There was a problem hiding this comment.
It wasn't entirely clear to me what that would do whereas tostring is simple to reason about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1107
Arizonia, and hopefully more, now ttx_diff equivalent.