Fix crater quality-of-life fix #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must use double-quotes for the outer quoting, to avoid collisions with the single-quotes used for the inner quoting. See b3faa37
|
No problem, thanks for the prompt fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately my fix for reproduction commands in #1103 – introducing bash quotes – interfered with the outer JavaScript quotes, breaking the 'copy reproduction command' entirely...
This PR remedies this by alternating the quotes style. For this and all future changes, I have now got a local fontc_crater setup, and have verified the fix. The documentation for doing so was excellent, and I wish I'd checked for it the first time; sorry for the trouble!
Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction