Support long parameter name for PANOSE, to match glyphsLib #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyphs supports longer alternative names for some of its parameters, with the short name taking precedence: https://github.com/googlefonts/glyphsLib/blob/050ef62c52906bc8ca820e7cfc6963138253f41f/Lib/glyphsLib/builder/custom_params.py#L322-L323 https://github.com/googlefonts/glyphsLib/blob/050ef62c52906bc8ca820e7cfc6963138253f41f/Lib/glyphsLib/builder/custom_params.py#L258-L269 This commit adds support for the longer name for the PANOSE values custom parameter, and tests that it is parsed and that its precedence is handled correctly, to improve parity with glyphsLib builds.
rsheeter
reviewed
Nov 7, 2024
| assert_eq!(Some(expected), context.static_metadata.get().misc.panose); | ||
| assert_eq!(expected, context.static_metadata.get().misc.panose); | ||
|
|
||
| // long parameter name |
There was a problem hiding this comment.
Could you please make these separate tests instead of having one test that does three seperable checks?
There was a problem hiding this comment.
Yes, good shout - I've split them now
rsheeter
reviewed
Nov 7, 2024
rsheeter
requested changes
Nov 7, 2024
rsheeter
approved these changes
Nov 7, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glyphsLib supports longer alternative names for some of its parameters, including PANOSE (albeit with the short name taking precedence). This PR adds support for the longer name, and tests that it is parsed and has its precedence weighed correctly.
With this change, most of the OS/2 diff for Noto Sundanese is resolved; an unrelated diff in
xAvgCharWidthremains.Before:
After:
Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction