Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crater] Fix repro command #1084

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[crater] Fix repro command #1084

merged 1 commit into from
Oct 31, 2024

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Oct 31, 2024

This is best effort. In particular,

  • it doesn't ensure that the git rev of the repo is the same
  • it assumes a single possible location for the checkouts
  • it doesn't ensure that the python toolchain is equivalent

but it does support gftools mode, and it does work?

based on #1083, which should go in first.

Base automatically changed from crater-rework-targets to main October 31, 2024 17:13
@cmyr cmyr added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit a4b28ca Oct 31, 2024
10 checks passed
@cmyr cmyr deleted the crater-fix-repro branch October 31, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @rsheeter