[write] Minor improvment to cmap 4 segmentation #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
commented
Nov 13, 2024
write-fonts/src/tables/cmap.rs
Outdated
| .as_ref() | ||
| // don't bother computing if we have already decided to merge | ||
| .filter(|next| !should_merge && current.can_merge(next)) | ||
| .map(|next| combined.combine(*next).cost() < prev.cost() + current.cost()) |
There was one case where fonttools was saving several bytes on us, which felt bad. We are now equal or better, for every font I've examined.
cmyr
force-pushed
the
cmap-size-followup
branch
from
dfaa41e
to
8bedb35
Compare
rsheeter
approved these changes
Nov 13, 2024
|
I'll close this and add it as a commit to #1228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one case where fonttools was saving several bytes on us, which felt bad. We are now equal or better, for every font I've examined.