Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer 2.x compatibility #49

Open
misi opened this issue Feb 3, 2018 · 8 comments
Open

Polymer 2.x compatibility #49

misi opened this issue Feb 3, 2018 · 8 comments

Comments

@misi
Copy link

misi commented Feb 3, 2018

Do you have any plans to make this Polymer2.x compatible element?
Does anyone from this community work on this?

I think it would be helpful to add a notice about that it is not yet a 2.x polymer compatible element.

Thanks for your help in advance!

@misi misi changed the title Polymer2.x compatibility Polymer 2.x compatibility Feb 3, 2018
@x1ddos
Copy link
Contributor

x1ddos commented Feb 15, 2018

Sorry for not replying earlier. I think we're moving away from Polymer completely and will be porting this to just plain Custom Elements, no frameworks/libraries.

@misi
Copy link
Author

misi commented Feb 16, 2018

Thanks.
I am definitely interested in your new project.

I see in chrome this warning, that says with chrome M65 will will break your actual codelab.
There are many ways to fix. Could you give me any hints, how to fix it?

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

Thanks a lot! & Appreciated your help and cooperation!

@x1ddos x1ddos self-assigned this Feb 16, 2018
@x1ddos
Copy link
Contributor

x1ddos commented Feb 16, 2018

Oh, thanks for reminding me! I completely forgot about that timeline.
I'm thinking to create googlecodelabs/codelab-elements, as opposed to this repo codelab-components.
Will check back here soon.

/cc @marcacohen @ebidel

@x1ddos
Copy link
Contributor

x1ddos commented Feb 16, 2018

So, the idea is to re-create <google-codelab>, <google-codelab-step> and <google-codelab-survey> using Custom Elements and style them with help from MDC.

This should be backwards-compatible. Existing exported codelabs markup must not change.

/cc @devnook.

@x1ddos
Copy link
Contributor

x1ddos commented Feb 27, 2018

FYI created a new repo at https://github.com/googlecodelabs/codelab-elements.
It's pretty much empty at the moment though, just a playground for some of my experiments. More coming soon.

@misi
Copy link
Author

misi commented Feb 28, 2018

Thank you for the update. I will check and follow it.
(I am not an exprtz on this field, but let me know if I could help..)

@billhimmelsbach
Copy link

Just as a head's up, the warning has been updated in Chrome Canary:

screen shot 2018-03-12 at 2 42 08 pm

Polymer/polymer#4679 (comment)

@x1ddos
Copy link
Contributor

x1ddos commented Apr 17, 2018

We've been quite active in the new repo. Things are starting to get into a nice shape.
See https://github.com/googlecodelabs/codelab-elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants