-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.state not preserved for resuming in this.async() #36
Comments
…not working Prepare a patch to reapply the fix for future use. Fixes #3 Reported upstream as googlecodelabs/codelab-components#36
…not working Prepare a patch to reapply the fix for future use. Fixes #3 Reported upstream as googlecodelabs/codelab-components#36
@didrocks I'm afraid we will not be fixing this here but we're working on a drop-in replacement using just Custom Elements spec, without Polymer or other frameworks/libs, in https://github.com/googlecodelabs/codelab-elements. See #49 for more details. |
I'm closing this as "won't fix" for now. But please let me know if anyone wants to contribute and fix it here and I'll reopen. Otherwise, please check out the new repo. |
First, thanks for the codelab-components! It's awesome and really useful to have opensourced this :)
I'm having an issue with resume not fired up. Adding some debug, I observed that this.state doesn't keep the same value in
_stateLoaded
before and afterthis.async()
call.I added some debug logs in _stateLoaded:
So, here is what I'm seeing, on page load:
As you can see,
this.state.stepIndex
has changed. This is due to_selectedChanged
being fired in between due tosteps
being initialized on attach.One way could be to prevent the
this.set('state.stepIndex', this.selected);
assignement on attach via a loading variable, do you think of a better fix? (It sounds wrong to change this.selected, as resume isn't selected at this point).The text was updated successfully, but these errors were encountered: