test: enable acceptance tests on emulator #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a mock server and several end-to-end tests using the mock server. Also fixes: - Invalid function calls in migrations - Unnecessary use of snapshots for INFORMATION_SCHEMA queries - Unnecessary SELECT 1 query each time a connection is checked out of the pool
Enables running the acceptance integration tests on the emulator. These finish in ~20 seconds instead of after several hours. All tests are green, except for one that is skipped, as Cloud Spanner does not support changing a nullable column to a not-null column for a table that already exists. Updates #65
Enables running the acceptance integration tests on the emulator. These finish in ~20 seconds instead of after several hours. All tests are green, except for one that is skipped, as Cloud Spanner does not support changing a nullable column to a not-null column for a table that already exists. Updates #65
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
…loite/ruby-spanner-activerecord into enable-acceptance-tests-on-emulator
xiangshen-dk
reviewed
Jun 7, 2021
lib/active_record/connection_adapters/spanner/schema_statements.rb
Outdated
Show resolved
Hide resolved
xiangshen-dk
approved these changes
Jun 7, 2021
hengfengli
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR also includes the same changes as #68. It is advisable to first review #68, or otherwise only review this PR)
Updates #65
Closes #48 and #47