fix(gas): Get rubygems key from keystore #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @zhangskz |
dazuma
force-pushed
the
pr/gas-keystore
branch
from
0e50f6c to
2741fe2
Compare
dazuma
force-pushed
the
pr/gas-keystore
branch
from
2741fe2 to
adc633f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitions the GAS kokoro jobs (notably the protobuf release job) to get their Rubygems keys from keystore instead of from GCS. This repurposes the existing
GAS_RUBYGEMS_KEY_FILEenvironment variable to specify the keystore file path (relative toKOKORO_KEYSTORE_DIR) instead of a gfile-based path (relative toKOKORO_GFILE_DIR) so that we don't have to define a new environment variable through the entire Kokoro config system.This should not be merged until the corresponding keystore key
rubygems-token-protobufhas been pushed (internal cl/697837917) and made accessible to the jobs (internal cl/697841636).