Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(spanner): use airlock for presubmit jobs #2199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci(spanner): use airlock for presubmit jobs #2199

wants to merge 1 commit into from

Conversation

sakthivelmanii
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Nov 26, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/node14/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Nov 26, 2024
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-presubmit-jobs branch from 137e50c to 08dddf6 Compare November 26, 2024 06:53
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2024
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-presubmit-jobs branch 2 times, most recently from ffaf8e6 to d851939 Compare December 30, 2024 04:31
suztomo
suztomo reviewed Jan 9, 2025
View reviewed changes
.kokoro/system-test.sh Show resolved Hide resolved
.kokoro/system-test.sh Show resolved Hide resolved
.kokoro/trampoline_v2.sh Outdated Show resolved Hide resolved
.kokoro/presubmit/node14/system-test.cfg Outdated Show resolved Hide resolved
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-presubmit-jobs branch 2 times, most recently from 1de73b7 to d38a124 Compare January 10, 2025 17:51
@sakthivelmanii sakthivelmanii added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-presubmit-jobs branch from d38a124 to e3e819f Compare January 10, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakthivelmanii @suztomo @surbhigarg92