Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin pydantic version to avoid a reasoning engine failure #284

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

vishwarajanand
Copy link
Contributor

Reasoning engine is failing in #283 hence this PR is needed to fix the tests.

Without this change, the tests in reasoning engine fail: test log saying:

NameError: name 'SafetySetting' is not defined. Did you mean: 'SafetySettingsType'?

which is caused due to below exception:

  File "/builder/home/.local/lib/python3.11/site-packages/pydantic/_internal/_generate_schema.py", line 1229, in _common_field_schema
    raise PydanticUndefinedAnnotation.from_name_error(e) from e
pydantic.errors.PydanticUndefinedAnnotation: name 'SafetySetting' is not defined

With this change, the tests in reasoning engine pass: test log.

Relevant issue in langchain repo: langchain-ai/langchain#28271

@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Dec 9, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review December 9, 2024 08:11
@vishwarajanand vishwarajanand requested review from a team as code owners December 9, 2024 08:11
@vishwarajanand vishwarajanand merged commit e7d2c05 into main Dec 10, 2024
12 checks passed
@vishwarajanand vishwarajanand deleted the fix-reasoning-engine branch December 10, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants