Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce Microsoft.Extensions.AI to AIPlatform #13814

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Krzysztof318
Copy link

@Krzysztof318 Krzysztof318 commented Nov 13, 2024

This is initial PR, its purpose is implement IChatClient from Microsoft.Extensions.AI.Abstractions LINK.

Before I jump into writing the implementation, please give me feedback on whether my approach is good for your repository.
Is the project location okay? Where can I add the unit tests?

@stephentoub I will glad to you if you also give me some help with this PR.

@jskeet
Copy link
Collaborator

jskeet commented Nov 13, 2024

It would be better to file an issue about what you want to achieve first, IMO. Personally I would prefer there to be another package that depends on both the existing AI Platform package and Microsoft.Extensions.AI to bridge the two, rather than adding a dependency directly - but @amanda-tarafa may have alternative suggestions.

@stephentoub
Copy link

I will glad to you if you also give me some help with this PR.

I'll be glad to help.

@amanda-tarafa
Copy link
Contributor

@Krzysztof318 do please file an issue explaining what your goal is, if there are alternatives to achieving that goal that you have discarded, etc. For instance, same as @jskeet I'd prefer a completely separate package, but we should discuss that.

Equally, we'd need to discuss internally about ongoing maintenance, etc. and accept (or not) the work accordingly.

It's better to have all those discussions in an issue that in PRs. You can then use PRs to demonstrate or support some of the technical decisions being discussed.

Thanks!

@Krzysztof318
Copy link
Author

@amanda-tarafa @jskeet Okay I will post issue tommorow

@Krzysztof318
Copy link
Author

I created an issue #13815 and I leave this PR for future concept purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants