Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused code #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: delete unused code #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ jobs:
fi

- name: staticcheck .
run: staticcheck -checks "inherit,-U1000" ./...
run: staticcheck ./...

- name: staticcheck ./examples
working-directory: ./examples
run: staticcheck -checks "inherit,-U1000" ./...
run: staticcheck ./...

- name: staticcheck ./benchmarks
working-directory: ./benchmarks
run: staticcheck -checks "inherit,-U1000" ./...
run: staticcheck ./...
7 changes: 0 additions & 7 deletions driver_with_mockserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3011,13 +3011,6 @@ func date(v string) civil.Date {
return res
}

func nullDate(valid bool, v string) spanner.NullDate {
if !valid {
return spanner.NullDate{}
}
return spanner.NullDate{Valid: true, Date: date(v)}
}

func nullJson(valid bool, v string) spanner.NullJSON {
if !valid {
return spanner.NullJSON{}
Expand Down
6 changes: 0 additions & 6 deletions integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,6 @@ func skipIfShort(t *testing.T) {
}
}

func skipIfEmulator(t *testing.T, msg string) {
if runsOnEmulator() {
t.Skip(msg)
}
}

func TestQueryContext(t *testing.T) {
skipIfShort(t)
t.Parallel()
Expand Down
3 changes: 1 addition & 2 deletions statement_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@ type clientSideStatement struct {
ResultType string `json:"resultType"`
Regex string `json:"regex"`
regexp *regexp.Regexp
MethodName string `json:"method"`
method func(query string) error
MethodName string `json:"method"`
ExampleStatements []string `json:"exampleStatements"`
ExamplePrerequisiteStatements []string `json:"examplePrerequisiteStatements"`

Expand Down
2 changes: 0 additions & 2 deletions testutil/mocked_inmem_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import (
// server and will return a one-col-two-rows result set containing the INT64
// values 1 and 2.
const SelectFooFromBar = "SELECT FOO FROM BAR"
const selectFooFromBarRowCount int64 = 2
const selectFooFromBarColCount int = 1

var selectFooFromBarResults = []int64{1, 2}

Expand Down