Linkify in AIP-0148 UID-format #1280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
It can be useful to know what the other values are even if they are not going to be used.
noahdietz
reviewed
Nov 1, 2023
| `(google.api.field_info).format = UUID4` annotation or has a format other than | ||
| `UUID4`. | ||
| `(google.api.field_info).format = UUID4` annotation or has a | ||
| [format](https://github.com/googleapis/googleapis/blob/master/google/api/field_info.proto#L54) |
There was a problem hiding this comment.
Would you mind doing a few things:
- Put this in a named link down at the bottom e.g.
[format]: https://....and changing this to[format][] - Remove the Line number - when targeting
masterit is potentially inaccurate
Alternatively, just link to AIP-202 where all of the formats are described.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to know what the other values are even if they are not going to be used.