Skip to content

Commit

Permalink
Update Truth to Guava 25.1.
Browse files Browse the repository at this point in the history
Includes a workaround for google/compile-testing#149

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=198895795
  • Loading branch information
dimo414 authored and ronshapiro committed Jun 1, 2018
1 parent 1420355 commit 882b776
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
10 changes: 8 additions & 2 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
<artifactId>truth</artifactId>
<name>Truth Core</name>
<properties>
<guava.version>23.6-android</guava.version>
<guava-gwt.version>23.6-jre</guava-gwt.version>
<guava.version>25.1-android</guava.version>
<guava-gwt.version>25.1-jre</guava-gwt.version>
<gwt.version>2.8.2</gwt.version>
<junit.version>4.12</junit.version>
<diffutils.version>1.3.0</diffutils.version>
Expand All @@ -31,6 +31,12 @@
<artifactId>checker-compat-qual</artifactId>
<version>${checker-framework.version}</version>
</dependency>
<!-- Manually add a dependency that guava-gwt needs but doesn't declare as of May 2018. -->
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
<version>${checker-framework.version}</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ public void comparableMixedTypesDontCompile() {

assertAbout(javaSource())
.that(file)
// https://github.com/google/compile-testing/issues/149
.withCompilerOptions("-sourcepath", "")
.failsToCompile()
.withErrorContaining("java.lang.String cannot be converted to test.MyTest.ComparableType")
.in(file)
Expand Down Expand Up @@ -84,6 +86,8 @@ public void rawComparableTypeMixedTypes() {
"}");
assertAbout(javaSource())
.that(file)
// https://github.com/google/compile-testing/issues/149
.withCompilerOptions("-sourcepath", "")
.failsToCompile()
.withErrorContaining(
"java.lang.String cannot be converted to test.MyTest.RawComparableType")
Expand Down

0 comments on commit 882b776

Please sign in to comment.