Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard/app: introduce authorized access to public resources #5407

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tarasmadan
Copy link
Collaborator

@tarasmadan tarasmadan commented Oct 15, 2024

  1. This PR unit test the accessLevel function internals and
  2. Introduces the authorized AccessPublic requests

We need AccessPublic authorization primarily to stop throttling our own service accounts.

@tarasmadan tarasmadan force-pushed the test_accesslevel branch 4 times, most recently from d81b7a6 to 5dec1bf Compare October 15, 2024 16:09
@tarasmadan tarasmadan changed the title [wip]test accesslevel dashboard/app: refactor authentication, introduce authorized access to public resources Oct 15, 2024
1. Main motivation - we want our service accounts to access dashboard w/o throttling.
2. Positive side affect - we can disable throttling for the specific users.
@tarasmadan tarasmadan marked this pull request as ready for review October 15, 2024 18:57
@a-nogikh
Copy link
Collaborator

  1. Introduces the authorized AccessPublic requests

We only need that to create the reproducers archive?

@dvyukov dvyukov requested review from a-nogikh and removed request for dvyukov October 16, 2024 08:34
@tarasmadan
Copy link
Collaborator Author

We only need that to create the reproducers archive?

I need it for reproducers now.

@tarasmadan
Copy link
Collaborator Author

@a-nogikh let's #5412 first then.

@tarasmadan
Copy link
Collaborator Author

tarasmadan commented Oct 18, 2024

Let's add the full ACL then?
What we have now is AuthDomains []string
Let use the next one instead:

type ACL struct{
    Email   string
    Domain  string
    Access  AccessLevel
}

Email != "" || Domain != "".
We can later add the Namespaces []string.
If the requester is authorized by this list - disable throttling.
@a-nogikh deal?

@tarasmadan tarasmadan changed the title dashboard/app: refactor authentication, introduce authorized access to public resources dashboard/app: introduce authorized access to public resources Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants