-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard/app: introduce authorized access to public resources #5407
Open
tarasmadan
wants to merge
4
commits into
google:master
Choose a base branch
from
tarasmadan:test_accesslevel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
test_accesslevel
branch
4 times, most recently
from
October 15, 2024 16:09
d81b7a6
to
5dec1bf
Compare
tarasmadan
force-pushed
the
test_accesslevel
branch
from
October 15, 2024 17:50
5dec1bf
to
bdac7f5
Compare
tarasmadan
changed the title
[wip]test accesslevel
dashboard/app: refactor authentication, introduce authorized access to public resources
Oct 15, 2024
tarasmadan
force-pushed
the
test_accesslevel
branch
from
October 15, 2024 17:54
bdac7f5
to
1f6b2ec
Compare
1. Main motivation - we want our service accounts to access dashboard w/o throttling. 2. Positive side affect - we can disable throttling for the specific users.
tarasmadan
force-pushed
the
test_accesslevel
branch
from
October 15, 2024 18:18
35dff54
to
0a69191
Compare
tarasmadan
force-pushed
the
test_accesslevel
branch
from
October 15, 2024 18:27
0a69191
to
4830329
Compare
tarasmadan
force-pushed
the
test_accesslevel
branch
from
October 15, 2024 18:46
e6154db
to
d3f3c03
Compare
We only need that to create the reproducers archive? |
I need it for reproducers now. |
Let's add the full ACL then? type ACL struct{
Email string
Domain string
Access AccessLevel
} Email != "" || Domain != "". |
tarasmadan
changed the title
dashboard/app: refactor authentication, introduce authorized access to public resources
dashboard/app: introduce authorized access to public resources
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need AccessPublic authorization primarily to stop throttling our own service accounts.