Skip to content

Commit

Permalink
Decorate config() as final - i.e., overriding it in a subclass is not…
Browse files Browse the repository at this point in the history
… permitted

PiperOrigin-RevId: 559538483
  • Loading branch information
The praxis Authors committed Aug 23, 2023
1 parent b89ade0 commit 49a17a2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions praxis/base_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,7 @@ def __to_sub_config_field__(cls):
def __call__(cls, *args, **kwargs):
return pax_fiddle.Config(cls.fiddle_base_layer_cls, *args, **kwargs)

@typing.final
def config(cls, **kwargs):
return cls(**kwargs)

Expand Down Expand Up @@ -2489,6 +2490,7 @@ def _quantize_fn(self, return_pspec: bool) -> NestedJTensor | Any:
res[target][var_name] = var_val
return res

@typing.final
@classmethod
def config(cls, **kwargs) -> pax_fiddle.Config:
return pax_fiddle.Config(cls, **kwargs)
Expand Down

0 comments on commit 49a17a2

Please sign in to comment.