Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate annot -> key #95

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Migrate annot -> key #95

merged 3 commits into from
Apr 3, 2024

Conversation

hchataing
Copy link
Collaborator

No description provided.

Annotations make it cumbersome to add new information
or operate ast transformations. Instead each node is
given a unique key identifier, which can be used
to reference the node in contextes.
@hchataing hchataing changed the title WIP migrate annot -> key Migrate annot -> key Mar 26, 2024
@hchataing hchataing requested review from mgeisler and DeltaEvo March 26, 2024 17:29
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Henri, this is cool in the way that it removes a lot of type-level shenanigans.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pdl-compiler/src/ast.rs Outdated Show resolved Hide resolved
pdl-compiler/src/parser.rs Outdated Show resolved Hide resolved
@hchataing hchataing merged commit 50b210f into main Apr 3, 2024
8 checks passed
@hchataing hchataing deleted the compound-field branch April 3, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants