Improve support for open enums in generated pytnon #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaEvo
approved these changes
Dec 23, 2023
- previously generated tags x_START and x_END for tag ranges, but IntEnum declarations are closed so parsing a value in these ranges would fail - instead removed declaration for range bounds, and relax the generated code to use Union[IntEnum, int] instead of IntEnum - provide IntEnum.from_int to validate values to are not matched to tags, that they are correctly inside of the ranges
Test enum declarations with exhaustive configurations for the
following criterias:
1. truncated: is the enum width a multiple of 8 or not ?
this characteristic has an impact for some language generators
2. complete: does the enum define all possible values ?
3. open: does the enum allow for unknown or undefined values ?
4. with range: does the enum use a tag range declarations ?
hchataing
force-pushed
the
python-open-enum
branch
from
54c181b to
529b4d3
Compare
DeltaEvo
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but IntEnum declarations are closed so parsing a value
in these ranges would fail
and relax the generated code to use
Union[IntEnum, int] instead of IntEnum
matched to tags, that they are correctly inside of the
ranges